Fix issue when setup:di:complie could unexpectedly crash with Directory not empty filesystem error

[theuargb]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @theuargb. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ihor-sviziev]

At first look, your fix looks as a workaround.

For better context, could you please provide some steps to reproduce, some exception stacktrace, or any other additional information?

[andrewbess]

Hello @ihor-sviziev
This happens sometimes and not often. Probably, if you do not enable maintenance mode in developer mode, and simultaneously cron or something else is running. That is, when the system has already cleared the generated directory during setup:upgrade. Still, between this action (clearing directory) and the subsequent setup:di:compile, some class has already been generated there and the directory is not empty.

[andrewbess]

Hello @theuargb
Thank you for your contribution.
It looks like a workaround, and this fix should not be in the system (IMHO).
Just, use setup commands more correctly.