Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decimal stock qty in feed builder #7

Closed
wants to merge 1 commit into from

Conversation

shamoon
Copy link

@shamoon shamoon commented Jul 11, 2023

Description (*)

If a store uses stock quantities that aren't ints the feed upload fails with e.g.

main.CRITICAL: Exception: Deprecated Functionality: Implicit conversion from float 9918.5 to int loses precision in .../vendor/meta/module-catalog/Model/Product/Feed/Builder/MultiSourceInventory.php on line 158 in .../vendor/magento/framework/App/ErrorHandler.php:61

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. Have a stock qty of eg 100.5
  2. Trigger manual upload

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@zlik
Copy link
Contributor

zlik commented Nov 26, 2024

Fixed in 1.3.5, closing the PR.

@zlik zlik closed this Nov 26, 2024
@shamoon
Copy link
Author

shamoon commented Nov 26, 2024

Not a big deal of course, but why even allow PRs if you dont review / merge them?

Screenshot 2024-11-26 at 11 27 31 AM

@shamoon shamoon deleted the patch-1 branch November 26, 2024 19:28
@zlik
Copy link
Contributor

zlik commented Nov 26, 2024

@shamoon, we do appreciate community contributions a lot and try to review and merge them as often as our team's capacity allows. Unfortunately, we don't have permissions to merge PRs in this repo because it's owned by a different org. But luckily we do have a process that allows for PRs to be merged through a private repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants