Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Security Policy for www.commercepartnerhub.com domain #86

Closed
wants to merge 1 commit into from

Conversation

robocrax
Copy link

Bug

When setting up the extension, my browser was blocking requests as www.commercepartnerhub.com was loading in an iframe

Meta extension csp blocked www commercepartnerhub com

Fixed Issues (if relevant)

No issue was created for this. Straight forward fix.

Manual testing scenarios (*)

NIL

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@robocrax robocrax changed the title Include www.commercepartnerhub.com in csp_whitelist.xml Content Security Policy for www.commercepartnerhub.com domain Sep 17, 2024
Copy link
Contributor

@zlik zlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @robocrax!

@zlik
Copy link
Contributor

zlik commented Dec 5, 2024

The PR will be merged in private repo (that's the only way for us to merge) and released in upcoming 1.3.6. Thank you for your contribution, @robocrax!

@zlik zlik closed this Dec 5, 2024
@zlik
Copy link
Contributor

zlik commented Dec 10, 2024

Actually, this is already fixed in bd63765, no need to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants