Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order of operations during multilan init #650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hazarth
Copy link

@Hazarth Hazarth commented Mar 18, 2025

Currently, the IP Mapping feature is broken due to calling the csipmap_init() function late after the map config was already read. This causes mooseFS to not find any mappings during runtime

Motivation and Context

Issue #649

Description

within multilan_init() I moved the call to csipmap_init() to the beginning of the function rather than the end, since IPMAP loading happens during multilan_reload().

How Has This Been Tested?

Tested on my own setup with a single mfsmaster that is on a VPN network with the chunkserver and the client. the client is also in direct LAN with the chunkserver. The fix was compiled and deployed and I tried streaming a video file from my existing MFS mount. Before the fix, the connection would be made via VPN even though the mfsipmap.cfg file was configured to use LAN IP. After the fix the stream was consumed from LAN as expected. the issue is described in detail in the issue ticket that I opened

This shouldn't affect any other part of code, the csipmap_init() function is pretty simple and benign, only setting global structures and values to NULL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Michal Pavlík <michal.sskk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant