-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module): handle tailwindcss import without theme(static)
#3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
β Deployed ui3
π View deployment logs |
theme(static)
theme(static)
benjamincanac
approved these changes
Mar 20, 2025
Awesome work @sandros94! Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Reference #3374, 85b45f6
β Type of change
π Description
Since Tailwindcss
4.0.8
it has been required to addtheme(static)
to all the tailwinds imports. The underline issue is that in the color's plugin we are not able to inform tailwind which color are being added in the page head.The solution I came with is to take advantage of
var()
fallback and populate it directly with upstream'soklch
string. The final output allows to both override the color with the localassets/css/main.css
as well as safely fallback to an empty string if an unsupported color is provided.The final
style
output looks something like:π Checklist