Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use :benchwarmer from mroth/benchwarmer@12b5a96 #80

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

cocoa-xu
Copy link
Contributor

Saw the following issue when running with Elixir 1.18.3 and OTP 27. :benchwarmer is outdated and v0.0.3 was never released on hex.pm.

    error: undefined variable "deps"
    │
  9 │       deps:         deps,
    │                     ^^^^
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:9:21: Benchwarmer.Mixfile.project/0

    error: undefined variable "description"
    │
 12 │       description:  description,
    │                     ^^^^^^^^^^^
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:12:21: Benchwarmer.Mixfile.project/0

    error: undefined variable "package"
    │
 13 │       package:      package
    │                     ^^^^^^^
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:13:21: Benchwarmer.Mixfile.project/0

    warning: function deps/0 is unused
    │
 53 │   defp deps do
    │        ~
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:53:8: Benchwarmer.Mixfile (module)

    warning: function description/0 is unused
    │
 17 │   defp description do
    │        ~
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:17:8: Benchwarmer.Mixfile (module)

    warning: function package/0 is unused
    │
 26 │   defp package do
    │        ~
    │
    └─ /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer/mix.exs:26:8: Benchwarmer.Mixfile (module)

Error while loading project :benchwarmer at /Users/cocoa/Library/Caches/mix/installs/elixir-1.17.2-erts-15.0/914f3a4f6f6fc1e79b2bec3e4f0efe0b/deps/benchwarmer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@epinault
Copy link
Contributor

epinault commented Apr 2, 2025

is that project benchwarmer still maintained? while this fixes the warning, would be nice to get the main of that project updated instead. did you open an issue with them?

@cocoa-xu
Copy link
Contributor Author

cocoa-xu commented Apr 2, 2025

is that project benchwarmer still maintained? while this fixes the warning, would be nice to get the main of that project updated instead. did you open an issue with them?

It doesn't appear to be actively maintained at the moment. I'm okay to open an issue there or we can switch to the new benchee?

@epinault
Copy link
Contributor

epinault commented Apr 2, 2025

I ll merge yours meanwhile to help but would be nice to get it fixed upstream for sure

@epinault epinault merged commit b09ad7e into erlef:main Apr 2, 2025
@epinault
Copy link
Contributor

epinault commented Apr 2, 2025

thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants