Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect z-index for Popover on top of SubNavListItem #5799

Open
zaviermiller opened this issue Mar 19, 2025 · 3 comments
Open

Incorrect z-index for Popover on top of SubNavListItem #5799

zaviermiller opened this issue Mar 19, 2025 · 3 comments
Assignees
Labels
bug Something isn't working react

Comments

@zaviermiller
Copy link

zaviermiller commented Mar 19, 2025

Description

There is a bug with the new Marketplace search functionality where our navigation items that have a sub-list are appearing over the search popover.

Here is a screenshot:

Image showing that the menu popover for marketplace search is underneath the navlist items with subnav items

The expected behavior of this page is that the popover and its elements appear on top of the list.

I have tracked the issue down to this line, and it appears that there has been a different PR that addressed a similar issue here.

Playing around in devtools shows the isolation fix from the PR does work here. Happy to open a PR to fix this!

Steps to reproduce

  1. Visit https://github.com/marketplace?type=apps&copilot_app=true
  2. Click the search bar and begin typing 'category'
  3. Click on the category item that appears in the popover
  4. Notice that the items from the popover are underneath the nav items with sub nav items.

Version

37.9.1

Browser

No response

@zaviermiller zaviermiller added the bug Something isn't working label Mar 19, 2025
@shraddhak1989
Copy link

@zaviermiller I want to work on this issue. Can you please guide which branch to clone.?

@sunnyi101
Copy link
Collaborator

Next steps would be to investigate the bug and figure out how much effort this would be

@TylerJDev TylerJDev self-assigned this Mar 24, 2025
@TylerJDev
Copy link
Member

Thanks for creating this issue @zaviermiller!

Playing around in devtools shows the isolation fix from the PR does work here. Happy to open a PR to fix this!

We'd definitely appreciate a PR if you have the time, but if not I can follow up with one! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

No branches or pull requests

4 participants