Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace python3 -m venv and pip with uv for virtual environment management #1030

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

josix
Copy link
Collaborator

@josix josix commented Mar 15, 2025

This pull request includes updates to the Makefile and README.rst to switch from using Python's venv and pip commands to the uv tool for virtual environment and package management.

Changes to Makefile:

  • Replaced python3 -m venv with uv venv for creating virtual environments.
  • Replaced python3 -m pip install with uv pip install for installing packages like sphinx, python-docs-theme, sphinx-lint, and blurb.
  • Updated the upgrade_venv target to use uv pip install -q --upgrade for upgrading packages.

Changes to README.rst:

  • Added a reference to uv Installation for installing uv to preview translation results locally.

@josix josix requested review from mattwang44 and ezio-melotti and removed request for mattwang44 March 15, 2025 07:47
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for this change?

@josix
Copy link
Collaborator Author

josix commented Mar 15, 2025

Hi @ezio-melotti, I'm mainly trying to speed up the time we spend preparing the environment, though it's not strictly necessary:) However, I'm also considering unifying the virtual environment in .scripts with the one used to build the docs. Maybe we could leverage uv's dependency group to manage them. What do you think? :)

@josix josix merged commit 3a5eeb5 into 3.13 Mar 15, 2025
1 check passed
@josix josix deleted the migrate-to-uv branch March 15, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants