Add Support SupplierReactiveClientRegistrationRepository #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projectsgh-16750 Signed-off-by: Max Batischev <mblancer@mail.ru>
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Apr 3, 2025
| public <T extends ReactiveClientRegistrationRepository & Iterable<ClientRegistration>> SupplierReactiveClientRegistrationRepository( | ||
| Supplier<? extends ReactiveClientRegistrationRepository> repositorySupplier) { | ||
| Assert.notNull(repositorySupplier, "repositorySupplier cannot be null"); | ||
| this.repositorySupplier = SingletonSupplier.of(repositorySupplier); |
There was a problem hiding this comment.
Are you able to change this logic to reflect SupplierReactiveJwtDecoder? I'd prefer to rely on reactive operations in this class since they are available to us.
There was a problem hiding this comment.
We have JwtDecoderInitializationException to indicate an error with lazy initialization of a JwtDecoder instance. Maybe it makes sense to introduce ClientRegistrationInitializationException in a separate commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16750