Improve error message when a workspace folder is inaccessible #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
approved these changes
Mar 20, 2025
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux when using a LSP client that does not support watching files on behalf of the server, we'll use Parcel Watcher (if possible). If we start the watcher with a non-existent or inaccessible directory, it will throw an error with a very unhelpful message: "Bad file descriptor".
The best thing we can do is an initial check for access to the directory and log a more helpful error message if it fails:
See #884 (comment)