Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: New partysocket version break deploy cli #1814

Closed
rharkor opened this issue Mar 22, 2025 · 9 comments
Closed

bug: New partysocket version break deploy cli #1814

rharkor opened this issue Mar 22, 2025 · 9 comments

Comments

@rharkor
Copy link

rharkor commented Mar 22, 2025

Provide environment information

System:
OS: Linux 6.11 Ubuntu 24.04.2 LTS 24.04.2 LTS (Noble Numbat)
CPU: (24) x64 AMD Ryzen AI 9 HX 370 w/ Radeon 890M
Memory: 20.41 GB / 30.44 GB
Container: Yes
Shell: 5.9 - /usr/bin/zsh
Binaries:
Node: 22.14.0 - ~/.nvm/versions/node/v22.14.0/bin/node
npm: 10.9.2 - ~/.nvm/versions/node/v22.14.0/bin/npm

Describe the bug

Partysocket package released the version 1.1.1, and it seems to break the current trigger deploy method of the cli.
https://www.npmjs.com/package/partysocket?activeTab=versions

Image

Reproduction repo

N/A

To reproduce

Remove the npx cache of trigger:
rm -rf ~/.npm/_npx/f51a09bd0abf5f10

Use the latest version of the cli and try to deploy

Additional information

No response

@ericallam
Copy link
Member

Image

Image

Yup, partysocket.1.1.1 looks to have shipped a broken ESM version in a patch release

@rharkor
Copy link
Author

rharkor commented Mar 22, 2025

@ericallam Maybe you can put a stable version in the package.json of trigger.dev

@ericallam
Copy link
Member

@rharkor could you try adding an override to your package.json to pin partysocket to a working version:

// npm
{
  "overrides": {
    "partysocket": "1.1.0"
  }
}
// yarn
{
  "resolutions": {
    "partysocket": "1.1.0"
  }
}
// pnpm should work with the overrides above but could also try
{
  "pnpm": {
    "overrides": {
      "partysocket": "1.1.0"
    }
  }
}

@ericallam
Copy link
Member

Weirdly partysocket hasn't updated their releases for 1.1.1 as of this moment

@rharkor
Copy link
Author

rharkor commented Mar 22, 2025

@rharkor could you try adding an override to your package.json to pin partysocket to a working version:

// npm
{
"overrides": {
"partysocket": "1.1.0"
}
}
// yarn
{
"resolutions": {
"partysocket": "1.1.0"
}
}
// pnpm should work with the overrides above but could also try
{
"pnpm": {
"overrides": {
"partysocket": "1.1.0"
}
}
}

I am using npx trigger.dev@latest so this will not work unfortunately. I will find a solution ty

@ericallam
Copy link
Member

@rharkor add the trigger.dev package to your devDependencies and then use the trigger command in your scripts. I've filed an issue with partysocket here: partykit/partykit#941

@rharkor
Copy link
Author

rharkor commented Mar 22, 2025

Actually I needed to add this to my package.json

"overrides": {
    "trigger.dev": {
      "partysocket": "1.1.0"
    }
}

@rharkor
Copy link
Author

rharkor commented Mar 22, 2025

@rharkor rharkor closed this as completed Mar 22, 2025
@threepointone
Copy link

threepointone commented Mar 23, 2025

if and when you have the time, can you check whether partysocket@0.0.0-bb008df works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants