Skip to content

Commit d97f06d

Browse files
committedOct 18, 2022
fix(build): use cldr.version for cldr
- more hyphen vs underscore Fixes #316
1 parent 387c470 commit d97f06d

File tree

4 files changed

+27
-9
lines changed

4 files changed

+27
-9
lines changed
 

‎.github/workflows/build-jsp.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ jobs:
2020
id: cldr_ref
2121
run: echo "CLDR_REF="$(mvn help:evaluate -Dexpression=cldr.version -q -DforceStdout | cut -d- -f3) >> $GITHUB_OUTPUT && cat ${GITHUB_OUTPUT}
2222
- name: Verify CLDR checkout ref
23-
run: echo CLDR_REF="${{ steps.cldr_ref.outputs.CLDR_REF }}" && [ "${{ steps.cldr-ref.outputs.CLDR_REF }}x" != "x" ] # fail if empty
23+
run: echo CLDR_REF="${{ steps.cldr_ref.outputs.CLDR_REF }}" && [ "${{ steps.cldr_ref.outputs.CLDR_REF }}x" != "x" ] # fail if empty
2424
- name: Check out CLDR
25-
uses: actions/checkout@v2
25+
uses: actions/checkout@v1 # yes, v1 due to https://github.com/actions/checkout/issues/265
2626
with:
2727
repository: unicode-org/cldr
2828
path: cldr
29-
ref: ${{ steps.cldr-ref.outputs.CLDR_REF }}
29+
ref: ${{ steps.cldr_ref.outputs.CLDR_REF }}
3030
- name: Backup Unicodetools and CLDR for jsps # this is needed only for the Docker build
3131
run:
3232
mkdir -p UnicodeJsps/target && tar cfpz UnicodeJsps/target/cldr-unicodetools.tgz ./cldr ./unicodetools

‎.github/workflows/cli-build-instructions.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,17 @@ jobs:
3939
steps:
4040
- name: Checkout Unicode Tools
4141
uses: actions/checkout@v3
42+
- name: Get the CLDR_REF from pom.xml
43+
id: cldr_ref
44+
run: echo "CLDR_REF="$(mvn help:evaluate -Dexpression=cldr.version -q -DforceStdout | cut -d- -f3) >> $GITHUB_OUTPUT && cat ${GITHUB_OUTPUT}
45+
- name: Verify CLDR checkout ref
46+
run: echo CLDR_REF="${{ steps.cldr_ref.outputs.CLDR_REF }}" && [ "${{ steps.cldr_ref.outputs.CLDR_REF }}x" != "x" ] # fail if empty
4247
- name: Check out CLDR
4348
uses: actions/checkout@v3
4449
with:
4550
repository: unicode-org/cldr
4651
path: cldr
52+
ref: ${{ steps.cldr_ref.outputs.CLDR_REF }}
4753
- name: Move CLDR working copy to be sibling of Unicode Tools
4854
run: |
4955
mv cldr ..
@@ -198,7 +204,7 @@ jobs:
198204
exit 1
199205
fi
200206
# TODO(#100): Note: when running locally on a clean checkout, this command
201-
# leaves a change in UcdPropertyValues.java by not preserving the comment
207+
# leaves a change in UcdPropertyValues.java by not preserving the comment
202208
# about the fake Unicode version 13.1.
203209
env:
204210
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -222,7 +228,7 @@ jobs:
222228
mvn -s .github/workflows/mvn-settings.xml compile exec:java -Dexec.mainClass="org.unicode.draft.GenerateUnihanCollators" -Dexec.args="" -am -pl unicodetools -DCLDR_DIR=$(cd ../../../cldr/mine/src ; pwd) -DUNICODETOOLS_GEN_DIR=$(cd ../Generated ; pwd) -DUNICODETOOLS_REPO_DIR=$(pwd) -DUVERSION=$CURRENT_UVERSION
223229
env:
224230
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
225-
231+
226232
# https://github.com/unicode-org/unicodetools/blob/main/docs/newunicodeproperties.md#checking-other-properties
227233
- name: Run command - Checking Other Properties
228234
run: |

‎.github/workflows/push-jsp-on-tag.yml

+15-3
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,29 @@ jobs:
77
build-and-push-to-gcr:
88
runs-on: ubuntu-latest
99
steps:
10-
- uses: actions/checkout@v2
10+
- uses: actions/checkout@v3
1111
- name: Set up JDK 11
1212
uses: actions/setup-java@v1
1313
with:
1414
java-version: 11
15-
- uses: actions/checkout@v2
15+
- name: Get the CLDR_REF from pom.xml
16+
id: cldr_ref
17+
run: echo "CLDR_REF="$(mvn help:evaluate -Dexpression=cldr.version -q -DforceStdout | cut -d- -f3) >> $GITHUB_OUTPUT && cat ${GITHUB_OUTPUT}
18+
- name: Verify CLDR checkout ref
19+
run: echo CLDR_REF="${{ steps.cldr_ref.outputs.CLDR_REF }}" && [ "${{ steps.cldr_ref.outputs.CLDR_REF }}x" != "x" ] # fail if empty
20+
- name: Cache CLDR
21+
uses: actions/cache@v2
22+
with:
23+
path: cldr
24+
key: cldr-${{ steps.cldr_ref.outputs.CLDR_REF }}
25+
restore-keys: |
26+
cldr-${{ steps.cldr_ref.outputs.CLDR_REF }}
1627
- name: Check out CLDR
17-
uses: actions/checkout@v2
28+
uses: actions/checkout@v1.2 # yes, v1 due to https://github.com/actions/checkout/issues/265
1829
with:
1930
repository: unicode-org/cldr
2031
path: cldr
32+
ref: ${{ steps.cldr_ref.outputs.CLDR_REF }}
2133
- name: Backup Unicodetools and CLDR for jsps
2234
run:
2335
mkdir -p UnicodeJsps/target && tar cfpz UnicodeJsps/target/cldr-unicodetools.tgz ./cldr ./unicodetools

‎.github/workflows/pythonpackage.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
python-version: [3.8]
1919

2020
steps:
21-
- uses: actions/checkout@v2
21+
- uses: actions/checkout@v3
2222
- name: Set up Python ${{ matrix.python-version }}
2323
uses: actions/setup-python@v1
2424
with:

0 commit comments

Comments
 (0)
Failed to load comments.