Skip to content

User defined languages #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

User defined languages #277

wants to merge 7 commits into from

Conversation

natecorkish
Copy link

This pull request gives the end user the choice to choose their own languages to show css completions. For example, say someone wants to add autocompletions to a file called .johndoe they can add it to their settings like so:

    "html-css-class-completion.enabledHTMLLanguages": [
        "html",
        "django-html",
        "razor",
        "php",
        "blade",
        "vue",
        "twig",
        "markdown",
        "erb",
        "handlebars",
        "ejs",
        "svelte",
       "johndoe"
    ],

This will save time for all the individual edge cases we have with people wanting support for different file types.

@vikbert
Copy link

vikbert commented Nov 22, 2020

nice feature. it will be nice to get this PR merged as soon as possible. thx.

@v-erse
Copy link

v-erse commented Nov 25, 2020

@zignd bump. This would be nice to have, love this extension but I can't use it with svelte!

@zignd
Copy link
Owner

zignd commented Nov 25, 2020

That's an amazing contribution @natecorkish! I'll test it and release it as soon as I can!

By the way, thanks for the mention @a6h-s, I totally missed the initial notification for this PR.

@zignd zignd self-requested a review November 25, 2020 02:41
@zignd
Copy link
Owner

zignd commented Nov 25, 2020

@natecorkish I was trying it out locally and it's working perfectly, but I did notice that when the user updates the configurations, the changes are not taking place. I believe it's likely because it's necessary to listen to those changes here in the code and then properly update the context.subscriptions.

Do you think you could add this detail as well? Otherwise I can still do it on my side once I merge it, no problem at all. Also, thanks for taking your time to implement it :)

@zignd
Copy link
Owner

zignd commented Dec 13, 2020

Merged to master manually 524b4f0. I'm still going to write some documentation tomorrow to explain this feature before the release and I'm also considering writing some tests as well.

@zignd zignd closed this Dec 13, 2020
@vikbert
Copy link

vikbert commented Feb 6, 2021

nice work. keep going. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants