Skip to content

jpadilla-redis: deprecate #208857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

jpadilla-redis: deprecate #208857

merged 1 commit into from
Apr 16, 2025

Conversation

khipp
Copy link
Member

@khipp khipp commented Apr 15, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Apr 15, 2025
@khipp khipp force-pushed the update-jpadilla-redis branch from ee8524e to 2b46073 Compare April 15, 2025 19:05
@krehel
Copy link
Member

krehel commented Apr 15, 2025

This may be a candidate for deprecation. It is several years and several major Redis versions out of date.

@bevanjkay
Copy link
Member

I agree that deprecation would be suitable here.

@khipp khipp force-pushed the update-jpadilla-redis branch from 2b46073 to 5725f32 Compare April 16, 2025 02:16
@BrewTestBot BrewTestBot added the cask deprecated Cask deprecated label Apr 16, 2025
@khipp khipp changed the title jpadilla-redis: add livecheck jpadilla-redis: deprecate Apr 16, 2025
@krehel krehel added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit 872d0c9 Apr 16, 2025
11 checks passed
@krehel krehel deleted the update-jpadilla-redis branch April 16, 2025 02:33
@khipp khipp removed the livecheck Issues or PRs related to livecheck label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask deprecated Cask deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants