Skip to content

Commit 6927266

Browse files
authored
Merge pull request #765 from github/parkerbxyz-updates
2 parents e801b3b + 212af88 commit 6927266

File tree

267 files changed

+428
-17713
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

267 files changed

+428
-17713
lines changed

Diff for: .github/ISSUE_TEMPLATE.md

+20-13
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,32 @@
11
## Overview
2-
**TL;DR**
3-
<One to two sentence description of the issue you are encountering or trying to solve.>
42

5-
### Extra Detail
3+
<!-- One to two sentence description of the issue you are encountering or trying to solve. -->
64

5+
### Extra detail
6+
7+
<!-- Please include any additional details that may be helpful in understanding the issue. -->
78
#### Screenshots
8-
<If bug fix, please upload images of the error to better showcase the problem.>
9+
10+
<!-- If bug fix, please upload images of the error to better showcase the problem. -->
911

1012
#### Reasoning
11-
<If new idea or direction, please create a checklist of proposed ideas or next steps. [Example](https://github.com/github/training-kit/issues/415).>
12-
13-
### How to Contribute
14-
- [ ] Comment on this issue if you'd like to work/collaborate on it!
15-
- [ ] Fork the [repository](https://github.com/github/training-kit).
16-
- [ ] Use the [GitHub Flow](https://guides.github.com/introduction/flow/) to make changes to your fork. [This](https://lab.github.com/githubtraining/introduction-to-github) is a refresher course if you're unsure about how to make a change on GitHub.
17-
- [ ] Push your changes to your repository.
18-
- [ ] Submit a Pull Request
13+
14+
<!-- If new idea or direction, please create a checklist of proposed ideas or next steps. [Example](https://github.com/github/training-kit/issues/415). -->
15+
16+
### How to contribute
17+
18+
- Comment on this issue if you'd like to work/collaborate on it!
19+
- Fork the [repository](https://github.com/github/training-kit).
20+
- Use the [GitHub Flow](https://guides.github.com/introduction/flow/) to make changes to your fork. [This](https://github.com/skills/introduction-to-github) is a refresher course if you're unsure about how to make a change on GitHub.
21+
- Push your changes to your repository.
22+
- Submit a Pull Request
1923
- Base Dropdown: github/training-kit
2024
- Compare Dropdown: Your fork
2125

22-
#### Testing Locally
26+
#### Testing locally
27+
2328
If you'd like to make and test changes locally (and see how they would look if merged), do the following:
29+
2430
- In your command line:
2531
- [Install Git](https://git-scm.com/)
2632
- [Install Ruby](https://www.ruby-lang.org/en/documentation/installation/)
@@ -29,4 +35,5 @@ If you'd like to make and test changes locally (and see how they would look if m
2935
- When successful, the script will initiate a local server at `http://127.0.0.1:4000/`.
3036

3137
### Questions?
38+
3239
- Leave a comment on this issue! Make sure to use `@mentions` if you want a specific person's attention!

Diff for: .github/PULL_REQUEST_TEMPLATE.md

+14-9
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
## Overview
2-
**TL;DR**
3-
<One to two sentence description of the issue you are encountering or trying to solve.>
42

5-
<Link to related issue. Type `closes #RELATEDISSUENUMBER` to establish a link.>
3+
<!--
4+
One to two sentence description of the issue you are encountering or trying to solve.
65
7-
### Questions
8-
<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
6+
Link to related issue. Type `closes #RELATED_ISSUE_NUMBER` to establish a link.
7+
-->
98

10-
### Next Steps
11-
<If incomplete, create a task list of items that are still being worked on within the Pull Request.>
9+
## Questions
1210

13-
### Review
14-
<If complete, or ready for :eyes:, use @mentions for quick questions, specific feedback, and progress updates.>
11+
<!-- If relevant, write a list of questions that you would like to discuss related to the changes that you have made. -->
12+
13+
## Next steps
14+
15+
<!-- If incomplete, create a task list of items that are still being worked on within the Pull Request. -->
16+
17+
## Review
18+
19+
<!-- If complete, or ready for :eyes:, use @mentions for quick questions, specific feedback, and progress updates. -->

Diff for: .github/workflows/jekyll.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ jobs:
1010
steps:
1111
- uses: actions/checkout@v2
1212

13+
# Node-specific steps
14+
- name: Install node modules
15+
run: |
16+
npm install
17+
1318
# Ruby-specific steps
1419
- name: Set up Ruby 2.6
1520
uses: actions/setup-ruby@v1
@@ -21,14 +26,9 @@ jobs:
2126
bundle install --jobs 4 --retry 3
2227
bundle exec rake
2328
24-
# Node-specific steps
25-
- name: Install node modules
26-
run: |
27-
npm install
28-
2929
# Jekyll-specific steps
3030
- name: Build the site in the jekyll/builder container
3131
run: |
3232
docker run \
3333
-v ${{ github.workspace }}:/srv/jekyll -v ${{ github.workspace }}/_site:/srv/jekyll/_site \
34-
jekyll/builder:latest /bin/bash -c "chmod a+w /srv/jekyll/Gemfile.lock && chmod 777 /srv/jekyll && jekyll build --future"
34+
jekyll/builder:latest /bin/bash -c "chmod a+w /srv/jekyll/Gemfile.lock && chmod 777 /srv/jekyll && jekyll build --future"

Diff for: CONTRIBUTING.md

+17-17
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,53 @@
11
# Contributing to training-kit
22

3-
:tada: Thank you for taking the time to contribute and for seeking out these instructions. We :heart: community contributions to these materials.
3+
🎉 Thank you for taking the time to contribute and for seeking out these instructions. We :heart: community contributions to these materials.
44

5-
<hr>
5+
---
66

77
## Code of Conduct
88

99
This project and everyone who participates in it is governed by the [Contributor Covenant Code of Conduct](CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code. Please report unacceptable behavior to [services@github.com](mailto:services@github.com).
1010

11-
<hr>
11+
---
1212

1313
## What should I know before I get started?
1414

1515
### The goal of these resources
1616

17-
These materials are designed to help those new to Git, GitHub and software development as a whole. By using these cheatsheets, we hope users will:
17+
These materials are designed to help those new to Git, GitHub and software development as a whole. By using these materials, we hope users will:
1818

1919
- Feel welcome and become active contributors in the open source community
20-
- Learn best practices for using Git, GitHub and other GitHub supported projects such as Electron, Atom, etc
20+
- Learn best practices for using Git and GitHub
2121
- Learn how to use the applications within GitHub's ecosystem to build better software
2222

2323
### Types of contributions we love
2424

2525
We're always looking for contributions to help improve these resources. This includes:
2626

27-
- Improving the existing cheatsheets
28-
- Translations of existing cheatsheets into new languages
29-
- Adding new classes or resources aligned with the [goals](#the-goal-of-these-resources)
27+
- Improving the existing cheat sheets
28+
- Translations of existing cheat sheets into new languages
29+
- Adding new courseware or resources aligned with the [goals](#the-goal-of-these-resources)
3030

31-
<hr>
31+
---
3232

3333
## How to contribute
3434

3535
### Report a bug
3636

3737
Oops, thanks for finding that! If you know how to fix it, please feel free to fork the repository and submit a change via Pull Request.
3838

39-
If you aren't sure how to fix it or just don't have time, we invite you to open a [new Issue](https://github.com/github/training-kit/issues/new). Please be sure to provide information so we can recreate the error.
39+
If you aren't sure how to fix it or just don't have time, we invite you to open a [new Issue](https://github.com/github/training-kit/issues/new). Please be sure to provide information, so we can recreate the error.
4040

4141
### Translate existing resources
4242

43-
Several community members have been kind enough to translate the Git Cheat Sheets into various languages. At this time, we are only set up to serve the cheat sheets in various languages (but maybe you can help us change that :wink:) If you are planning to contribute a translation, please do the following:
43+
Several community members have been kind enough to translate the Git Cheat Sheets into various languages. At this time, we are only set up to serve the cheat sheets in various languages (but maybe you can help us change that 😉). If you are planning to contribute a translation, please do the following:
4444

4545
- Fork this repository
46-
- Create a new folder in the [downloads directory](https://github.com/github/training-kit/tree/master/downloads) using the standard abbreviation for the language you are providing.
47-
- Copy the most recent [English version of the cheatsheet](https://github.com/github/training-kit/blob/master/downloads/github-git-cheat-sheet.md) to the folder you created.
46+
- Create a new folder in the [downloads directory](https://github.com/github/training-kit/tree/main/downloads) using the standard abbreviation for the language you are providing.
47+
- Copy the most recent [English version of the cheat sheet](https://github.com/github/training-kit/blob/main/downloads/github-git-cheat-sheet.md) to the folder you created.
4848
- Complete the translation
49-
- Add a link to the translated resource on [/index.html](https://github.com/github/training-kit/blob/master/index.html)
50-
- Open a pull request against the `master` branch of this repository.
49+
- Add a link to the translated resource on [/index.html](https://github.com/github/training-kit/blob/main/index.html)
50+
- Open a pull request against the `main` branch of this repository.
5151
- Be sure to @ mention a couple of your friends who are native speakers and ask them to review the translation.
5252
- Update your translation based on feedback from your friends.
5353

@@ -63,7 +63,7 @@ When you are contributing something new, we ask you to be familiar with our cont
6363

6464
If you just want to help out, but don't have a particular change in mind, check out the [open issues](https://github.com/github/training-kit/issues) for projects you can tackle, review an [open pull request](https://github.com/github/training-kit/pulls), or check out [the project ROADMAP](https://github.com/github/training-kit/projects/1).
6565

66-
<hr>
66+
---
6767

6868
### Styling content
6969

@@ -81,4 +81,4 @@ To build the materials do the following:
8181
1. Run `script/build` to build the site
8282
1. Run `script/server`
8383
- When successful, the script will initiate a local server at `http://127.0.0.1:4000/`.
84-
1. Simply paste that into your favorite web-browser and you will be ready to test
84+
1. Simply paste that into your favorite web-browser, and you will be ready to test

Diff for: Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
source "https://rubygems.org"
22

3-
gem 'github-pages', '~> 219', group: :jekyll_plugins
3+
gem 'github-pages', group: :jekyll_plugins
44
gem 'html-proofer'
5-
gem 'rack-contrib', '~> 1.1.0'
5+
gem 'rack-contrib'
66
gem 'rake'
77
gem 'jekyll-octicons'

0 commit comments

Comments
 (0)