Skip to content

Commit 11aaa65

Browse files
author
IvanZosimov
committed
Fix review points
1 parent 338d4e3 commit 11aaa65

File tree

7 files changed

+23
-17
lines changed

7 files changed

+23
-17
lines changed

Diff for: .github/workflows/basic-validation.yml

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Basic validation
2+
3+
on:
4+
pull_request:
5+
paths-ignore:
6+
- '**.md'
7+
push:
8+
branches:
9+
- main
10+
- releases/*
11+
paths-ignore:
12+
- '**.md'
13+
14+
jobs:
15+
call-basic-validation:
16+
name: Basic validation
17+
uses: actions/reusable-workflows/.github/workflows/basic-validation.yml@main

Diff for: .github/workflows/check-dist.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ on:
1212
workflow_dispatch:
1313

1414
jobs:
15-
call-check-dist: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/check-dist.yml
15+
call-check-dist:
1616
name: Check dist/
1717
uses: actions/reusable-workflows/.github/workflows/check-dist.yml@main

Diff for: .github/workflows/codeql-analysis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ on:
99
- cron: '0 3 * * 0'
1010

1111
jobs:
12-
call-codeQL-analysis: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/codeql-analysis.yml
12+
call-codeQL-analysis:
1313
name: CodeQL analysis
1414
uses: actions/reusable-workflows/.github/workflows/codeql-analysis.yml@main

Diff for: .github/workflows/workflow.yml renamed to .github/workflows/e2e-tests.yml

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Main workflow
1+
name: e2e tests
22

33
on:
44
pull_request:
@@ -12,10 +12,6 @@ on:
1212
- '**.md'
1313

1414
jobs:
15-
call-basic-validation: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/basic-validation.yml
16-
name: Basic validation
17-
uses: actions/reusable-workflows/.github/workflows/basic-validation.yml@main
18-
1915
test-setup-multiple-versions:
2016
runs-on: ${{ matrix.operating-system }}
2117
strategy:
@@ -324,4 +320,4 @@ jobs:
324320
env:
325321
NUGET_AUTH_TOKEN: NOTATOKEN
326322
- name: Verify dotnet
327-
run: __tests__/verify-dotnet.sh 3.1.201
323+
run: __tests__/verify-dotnet.sh 3.1.201

Diff for: .github/workflows/licensed.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ on:
1010
workflow_dispatch:
1111

1212
jobs:
13-
call-licensed: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/licensed.yml
13+
call-licensed:
1414
name: Licensed
1515
uses: actions/reusable-workflows/.github/workflows/licensed.yml@main

Diff for: __tests__/verify-no-unstaged-changes.sh

-7
This file was deleted.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "tsc && ncc build",
99
"format": "prettier --write **/*.ts",
1010
"format-check": "prettier --check **/*.ts",
11-
"lint": "",
11+
"lint": "echo \"Fake command that does nothing. It is used in reusable workflows\"",
1212
"prepare": "husky install",
1313
"test": "jest --coverage --config ./jest.config.js",
1414
"update-installers": "nwget https://dot.net/v1/dotnet-install.ps1 -O externals/install-dotnet.ps1 && nwget https://dot.net/v1/dotnet-install.sh -O externals/install-dotnet.sh"

0 commit comments

Comments
 (0)