Skip to content

Upgraded to new version of python #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: refactor-into-subclasses
Choose a base branch
from

Conversation

ErikKiss-FunnyFox
Copy link

Upgraded to python 3.12.
Added some testing.
Fixed a bug pertaining to loading file from package (new_schedule.txt) using module-based directory discovery.

Fixed lookup_table adjudicator to create data dir if it doesn't exist.
Fixed data file loading.
Currently, QuantumAnnealing adjudicator doesn't work.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to Python 3.12, adds new tests for the adjudicators, and fixes a bug in how the schedule file is loaded.

  • Upgraded dependency versions and Python version in pyproject.toml
  • Added tests in tests/test_adjudicators.py to validate adjudicators with a random game
  • Updated file-loading logic in tangled_adjudicate/schrodinger/sparse_matrices.py and improved the lookup table setup to auto-create the data directory

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
tests/test_adjudicators.py Introduces tests to exercise the adjudicators using a random game scenario
tangled_adjudicate/schrodinger/sparse_matrices.py Revises schedule file loading logic to use package resources, but misses a numpy import
tangled_adjudicate/adjudicators/lookup_table.py Adjusts setup to create the data directory if it doesn’t exist
pyproject.toml Updates the Python version and dependency versions for compatibility with Python 3.12
Files not reviewed (1)
  • .bumpversion.cfg: Language not supported
Comments suppressed due to low confidence (1)

tangled_adjudicate/schrodinger/sparse_matrices.py:95

  • Missing import for numpy; add 'import numpy as np' at the top of the file to support np.loadtxt.
data = np.loadtxt(file_path)       # Import SR8 qubit information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant