dovecot 2.4.1-4

[botantony]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

This doesn't pass tests at this moment because there's no /etc/dovecot/ssl-cert.pem file. $HOMEBREW_PREFIX/etc/dovecot/dovecot.conf has this at the end:

ssl_server {
  cert_file = /etc/dovecot/ssl-cert.pem
  key_file = /etc/dovecot/ssl-key.pem
}

I can provide path to certificate file from ca-certificates formula (similar to how libressl has post_install method that does this) but I'm not sure what to do with key_file. Hope someone could help me figure this out

[Bo98]

Upstream still call it 2.4.1 so unclear whether we should call it 2.4.1 or 2.4.1-4: https://github.com/dovecot/core/releases/tag/2.4.1. Maybe worth comparing to dovecot --version

[botantony]

recompiled it again just for version test, dovecot --version prints version with revision number:

# 2.4.1-4 (7d8c0e5759): /opt/homebrew/etc/dovecot/dovecot.conf
# Pigeonhole version 2.4.0 (1b2d5bb9)

i guess it makes more sense to stick to regex that includes revision number (easier for us + the program says so)

[Bo98]

yeah regex is fine, was more a question of whether to stick a version "2.4.1" or not. Seems like upstream use both formats interchangeably.

That version output does remind me though that you need to update the pigeonhole resource too.

[botantony]

2.4.0 is the latest available version for pigeonhole

[Bo98]

Release email mentions pigeonhole: https://dovecot.org/mailman3/archives/list/dovecot-news@dovecot.org/thread/XPT6TA7Y4B4QZZQ2XUE46Z35BDR2X2AA/

Also tagged on GitHub and presumably included in the Dovecot docker image if you want to check.

Seems like this release has been largely incomplete: dovecot.org homepage not updated, pigeonhole download page not updated, Docker image still points 2.4-latest to 2.4.0.