-
Notifications
You must be signed in to change notification settings - Fork 183
Add support for api_version property in app toml access.admin
module
#5994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for api_version property in app toml access.admin
module
#5994
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success2884 tests passing in 1254 suites. Report generated by 🧪jest coverage report action from ee774bf |
/snapit |
🫰✨ Thanks @alfonso-noriega! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/cli@0.0.0-snapshot-20250619120839 Tip If you get an Caution After installing, validate the version by running just |
Related |
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
@@ -11,6 +11,7 @@ const AppAccessSchema = BaseSchema.extend({ | |||
.object({ | |||
direct_api_mode: zod.union([zod.literal('online'), zod.literal('offline')]).optional(), | |||
embedded_app_direct_api_access: zod.boolean().optional(), | |||
admin_api_version: zod.string().optional(), | |||
}) | |||
.optional(), | |||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Re: line +44]
I think you also need to do add it here so that the value is sent in the config during deploy 🤔
See this comment inline on Graphite.
WHY are these changes introduced?
To support specifying an admin API version in the app configuration.
WHAT is this pull request doing?
Adds an optional
admin_api_version
field to the app configuration schema, allowing developers to specify which version of the Admin API their direct api requests should use.How to test your changes?
admin_api_version
field specifiedMeasuring impact
How do we know this change was effective? Please choose one:
Checklist