Skip to content

Simplify theme command environment paths #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

EvilGenius13
Copy link
Contributor

@EvilGenius13 EvilGenius13 commented Jun 19, 2025

WHY are these changes introduced?

Follow up to #5954 (comment)

We can further simplify the codepaths that a theme command can go through.

WHAT is this pull request doing?

In both no environment and single environment scenarios, they both make a session and then run the command. They are now lumped together based on what the environments variable has.

How to test your changes?

  • Pull down the branch
  • Build the branch
  • Run a series of commands
    • shopify theme list
    • shopify theme list -e mystore
    • shopify theme list -e mystore -e myotherstore
  • Ensure commands output the proper store(s)

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@EvilGenius13 EvilGenius13 changed the title change theme command code to have two environment paths Simplify theme command environment paths Jun 20, 2025
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.32% (+0.01% 🔼)
12542/16013
🟡 Branches
72.5% (+0.03% 🔼)
6105/8421
🟡 Functions 78.47% 3272/4170
🟡 Lines
78.77% (+0.01% 🔼)
11867/15066
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / theme-command.ts
38.78% (-4.62% 🔻)
12.5% (-6.73% 🔻)
40%
42.22% (-4.72% 🔻)

Test suite run success

2902 tests passing in 1259 suites.

Report generated by 🧪jest coverage report action from d45304d

@EvilGenius13 EvilGenius13 marked this pull request as ready for review June 23, 2025 14:02
@EvilGenius13 EvilGenius13 requested review from a team as code owners June 23, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants