Add "listing" flag support to theme commands #6007
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6002.
WHY are these changes introduced?
Shopify introduced new requirements for the Shopify Theme Store that require themes with multiple presets to include a
/listings
directory in their theme zip submissions. However, developers need a way to preview and test these specific theme presets during development and deployment.WHAT is this pull request doing?
--listing
flag toshopify theme dev
,shopify theme push
, andshopify theme share
commandsconfig/settings_data.json
preset switching, i.e."current" key
, based on listing nameHow to test your changes?
Create a theme with a
listings/
directory:Test development with listing:
Test push with listing:
Test share with listing:
Verify that listing-specific files are served when they exist, and base theme files are used as fallbacks when they don't
Measuring impact
How do we know this change was effective? Please choose one:
Checklist