[Feature] Add support for a global .shopifyignore file in user's home directory #6018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshaw
commented
Jun 26, 2025
|
|
||
| const content = await readFile(shopifyIgnorePath, {encoding: 'utf8'}) | ||
| async function readIgnoreFile(path: string) { |
There was a problem hiding this comment.
Not really a fan of this approach, much simpler to due do via flatMap in getPatternsFromShopifyIgnore but given await's semantics (await is an anti-pattern IMHO and this is just another example) it was a cleaner approach 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Stems from #5951.
I wouldn't add Emacs-specific ignore patterns to a repo's
.gitignoreas Emacs ignores are specific to my environment and others may use VS Code etc... I'd put patterns specific to my environment in~/.gitignore. Same applies to.shopifyignore.WHAT is this pull request doing?
Expanding the search for ignore patterns from the project root's
.shopifyignoreto include~/.shopifyignore.How to test your changes?
pnpm vitest run packages/theme/src/cli/utilities/asset-ignore.test.tsPost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
🤷
Checklist
Can open a PR for doc changes if approved.