Skip to content

Support ActionMailbox callbacks for Definition requests #377

New issue
New issue
Open
#617
Open
Support ActionMailbox callbacks for Definition requests#377
#617
Labels
good-first-issueGood for newcomershelp-wantedExtra attention is needed
@andyw8

Description

@andyw8
andyw8
opened on May 13, 2024
Contributor

Similar to what we do for ActiveRecord callbacks, we could support the 3 callbacks that ActionMailbox provides:

  • around_processing
  • before_processing
  • after_processing

https://api.rubyonrails.org/classes/ActionMailbox/Callbacks.html

Activity

andyw8
added
good-first-issueGood for newcomers
on May 13, 2024
aniketpatidar

aniketpatidar commented on Jul 30, 2024

@aniketpatidar
aniketpatidar
on Jul 30, 2024

I would like to tackle this one!

egiurleo
added
help-wantedExtra attention is needed
on Apr 2, 2025
domingo2000
linked a pull request that will close this issue on Jun 1, 2025
domingo2000

domingo2000 commented on Jun 1, 2025

@domingo2000
domingo2000
on Jun 1, 2025
Contributor

@andyw8 I just added a PR to solve this by reusing the implementation for ActiveRecord callbacks. Happy to receive feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good-first-issueGood for newcomershelp-wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @andyw8@egiurleo@domingo2000@aniketpatidar

      Issue actions
        Support ActionMailbox callbacks for Definition requests · Issue #377 · Shopify/ruby-lsp-rails