Rescue more exceptions in error handlers #628
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jun 18, 2025
We could, I opted for consistency with other rescue's. I'll change it. |
KaanOzkan
force-pushed
the
ko/rescue-more-exceptions
branch
from
2c96180 to
7635096
Compare
We were only rescuing StandardError's but we can also rescue some of the Exception class descendants
KaanOzkan
force-pushed
the
ko/rescue-more-exceptions
branch
from
7635096 to
7aca10f
Compare
vinistock
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only rescuing StandardError's but we can also rescue some of the Exception class descendants