Replace stdin with preinitialized input buffer #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,6 +99,7 @@ fn run_example(example: &str, input_bytes: Vec<u8>) -> Result<(Vec<u8>, u64)> { | |||
|
|
|||
| let instance = linker.instantiate(&mut store, &module)?; | |||
|
|
|||
| store.set_fuel(STARTING_FUEL)?; | |||
There was a problem hiding this comment.
One note here: I think we want to set the fuel before the previous line e.g.,
store.set_fuel(STARTING_FUEL)?;
let instance = linker.instantiate(&mut store, &module)?;since there's code that could run at instantiation time, e.g., the start function.
| @@ -43,7 +43,7 @@ fn assert_fuel_consumed_within_threshold(target_fuel: u64, fuel_consumed: u64) { | |||
| } | |||
| } | |||
|
|
|||
| fn run_example(example: &str, input_bytes: Vec<u8>) -> Result<(Vec<u8>, u64)> { | |||
| fn run_example(example: &str, input_bytes: Vec<u8>, use_wasi: bool) -> Result<(Vec<u8>, u64)> { | |||
There was a problem hiding this comment.
Minor nit: what do you think of avoiding the usage of bool params?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using WASI standard input to get input, have the host call an exported function to initialize an in-memory buffer for the input, then copy the input into the buffer, then reset the fuel counter and call the function. This excludes our code that loads the data from the limits imposed on the partner function (though we could choose to subject this function to the limits as well) and replaces n hostcalls with a single call to an exported function to setup the input.