Replace stdout with a finalize function #97
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a proposal for how to stop using stdout. This builds on using a singleton context. We remove the
finalize
function from the API we expose to partner code and create an exportedfinalize
function for the host environment to call which will return a pointer and length to the output buffer. We can exclude calling thisfinalize
function from the fuel and timeout limits.A tradeoff is we lose performing a final validation of the
WriteState
in the partners' function. We could move that check to ourfinalize
function or otherwise validate the state of the output vector on the host. That would change how an invalid output surfaces from a function trap to some other form of output error.