Added ACTIONS_RUNNER_INJECT_RUNNER_SERVICE_ACCOUNT environment variable #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable and implementation
ghost
requested review from
…variable and implementation
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team! :)
As mentioned here, we in eDo hit the same behavior of @Hchanni.
Analysing the problem, we found out that when a runner starts a
-workflowpod with hooks, it doesn't automatically propagate its service account.In our case with Workload Identities, this is needed, and even if we can workaround the problem creating a ConfigMap and placing in the runner container as a file to make an override (using
ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE), this is still a feature that could be helpful for lot of people.This won't be the default behavior because I understand it's a breaking change, but I added a new environment variable
ACTIONS_RUNNER_INJECT_RUNNER_SERVICE_ACCOUNTto allow the automatic "parent injection"