Skip to content

undici is not listed as a dependency for @actions/github package in NPM #1993

Closed
@cemreyavuz

Description

@cemreyavuz

Ref to #1684, undici is added as a dependency to @actions/github recently: #1957. However, the package version for @actions/github is not bumped and published - latest version of the package still doesn't have undici as a dependency. In our PNPM repository, our custom actions using @actions/github fail because we cannot find undici. At the moment, we can work around it by adding a package extension. However, for the permanent fix, I believe we need to publish a new version of @actions/github with the recent change.

The code for @actions/github@6.0.0 can be found here: https://www.npmjs.com/package/@actions/github?activeTab=code. If you look at package.json, you will see that undici is missing. And this is the output when i run npm info @actions/github@6.0.0 (you can see undici is not part of dependencies here either):

@actions/github@6.0.0 | MIT | deps: 4 | versions: 17
Actions github lib
https://github.com/actions/toolkit/tree/main/packages/github

keywords: github, actions

dist
.tarball: https://cognite.jfrog.io/artifactory/api/npm/npm-virtual/@actions/github/-/github-6.0.0.tgz
.shasum: 65883433f9d81521b782a64cc1fd45eef2191ea7
.integrity: sha512-alScpSVnYmjNEXboZjarjukQEzgCRmjMv6Xj47fsdnqGS73bjJNDpiiXmp8jr0UZLdUB6d9jW63IcmddUP+l0g==

dependencies:
@actions/http-client: ^2.2.0                   @octokit/core: ^5.0.1                          @octokit/plugin-paginate-rest: ^9.0.0          @octokit/plugin-rest-endpoint-methods: ^10.0.0 

maintainers:
- chrispat <chrispat@github.com>
- bryanmacfarlane <bryanmacf@gmail.com>
- thboop <thboop@github.com>
- konradpabjan <konradpabjan@github.com>
- cschleiden <cschleiden@outlook.com>
- joshmgross <joshmgross@github.com>

dist-tags:
latest: 6.0.0  

published a year ago by thboop <thboop@github.com>

I skimmed through the docs in the repo and I couldn't find information around how the version bumps are done in the repository. I'm happy to look into it if there are any guidelines for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions