Skip to content

fix: optimize IPv4 hostname serialization #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: optimize IPv4 hostname serialization #958

wants to merge 1 commit into from

Conversation

mertcanaltin
Copy link
Contributor

I removed the duplicate serialization call and stored the result in a variable

anonrig
anonrig requested changes Jun 14, 2025
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't change anything?

@mertcanaltin
Copy link
Contributor Author

This doesn't change anything?

I wanted to try to keep it in a variable here, but I think the compiler already optimized it automatically. I will close this PR. thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertcanaltin @anonrig