Skip to content

Should we diable folder-image generation for other forks? #404

Open
@FoamyGuy

Description

@FoamyGuy

The images.yml file has a scheduled task that runs once per day to generate the folder images for all example code from the libraries in the bundle.

on:
schedule:
- cron: '0 10 * * *'
workflow_dispatch:

It seems this scheduled task runs on all forks of this repo (assuming their default branch is up-to-date enough to contain the images.yml file). Here is an output from that workflow running in my fork: https://github.com/FoamyGuy/Adafruit_CircuitPython_Bundle/actions/runs/3162062950 I checked one or two others at random and did find more with the scheduled workflow in it.

Should we add some sort of limitation that makes this action only run for the adafruit org fork of the repo's instead of everyones? The generated images in adafruit org are the only ones that are widely used AFAIK

We use a limitation like that here: https://github.com/adafruit/circuitpython/blob/bced76887e49e0a30a0e116ef5a4feed7f3d240e/.github/workflows/build.yml#L118

github.repository_owner == 'adafruit'

It could perhaps be used similarly in this image generator workflow to limit it so it won't run for other users (unless they modify the workflow.yml file to change it).

If we decide to make this change, it's probably worthwhile to do the same thing over in the Learn Guide repo because It uses the same type of cron scheduled workflow that also seems to run for other users as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions