Skip to content

adding some icons and metadata for fruitjam os #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

FoamyGuy
Copy link
Collaborator

@FoamyGuy FoamyGuy commented Jun 17, 2025

These icon and metadata.json files get used by the fruit jam OS launcher.

Other changes include:

  • swapping a few projects to use the adafruit_fruitjam library to request a display size instead of assuming the appropriate one, or manually initializing it.
  • change the behavior of exiting in a few cases to integrate with the fruit jam OS launcher better.
  • use adafruit_usb_descriptors helper to find appropriate mouse USB interface instead of assuming the first one found is correct.

Copy link
Collaborator

@TheKitty TheKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FoamyGuy - would it be better that the request_display_config routine be in displayio rather than a Fruit Jam library when it might be used in non-Fruit Jam projects?

@FoamyGuy
Copy link
Collaborator Author

@TheKitty I think it's not applicable for most of normal displayio stuff because typically hardware displays like OLED, LCD, eink etc, have a fixed resolution that they need to be initialized at. picodvi is different in that it allows a few different resolutions and configurations.

I think there could be some merit in adding a helper function like this to picodvi in the core, especially if we foresee a future where larger resolutions get supported as well. Though it is a bit tricky because this code also relies on hard-coded pin names (https://github.com/adafruit/Adafruit_CircuitPython_FruitJam/blob/4c3a50d0bff9dd5f93e8f2fae395d7834d5111b0/adafruit_fruitjam/peripherals.py#L66-L73) I believe the pin naming scheme used is the same for the Metro RP2350 and the Fruit Jam so both of those devices could use this helper but newer or 3rd party devices would only be able to use if they match this naming / usage of the data pins.

It would be essentially codifying this pin naming/usage into a defacto default "standard" of sorts for picodvi moving forward. Though user code can always fall back to the normal more specific API to provide their own different pins as well.

@FoamyGuy FoamyGuy merged commit 82e3a2a into adafruit:main Jun 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants