-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
CircuitPython version and board name
Adafruit CircuitPython 10.0.0-alpha.6 on 2025-05-17; Adafruit Metro RP2350 with rp2350b
Code/REPL
= TilePaletteMapper(shader_palette, 2, SCREEN_WIDTH, SCREEN_HEIGHT)
from https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/54ab01feadf4206fa5ec1b5f22c6e2f646e2c0bc/Metro/Metro_RP2350_CircuitPython_Matrix/code.py#L67
(works fine in 9.x and fail in 10.0.0-alpha6)
Behavior
File "code.py", line 67, in <module>
TypeError: extra positional arguments given
]0;🐍67@code.py TypeError | 10.0.0-alpha.6\
Description
The definition of tilepalettemapper.TilePaletteMapper has changed between 9.2.x and 10.0.0-alpha
(9)
https://docs.circuitpython.org/en/9.2.x/shared-bindings/tilepalettemapper/index.html#tilepalettemapper.TilePaletteMapper
class tilepalettemapper.TilePaletteMapper(palette: displayio.Palette, input_color_count: int, width: int, height: int)
vs
(10)
https://docs.circuitpython.org/en/latest/shared-bindings/tilepalettemapper/index.html#tilepalettemapper.TilePaletteMapper
class tilepalettemapper.TilePaletteMapper(palette: displayio.Palette, input_color_count: int)
This is a breaking change for some code such as line 67 here:
https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/54ab01feadf4206fa5ec1b5f22c6e2f646e2c0bc/Metro/Metro_RP2350_CircuitPython_Matrix/code.py#L67
from Learn guide https://learn.adafruit.com/return-to-the-matrix-with-the-metro-rp2350/circuitpython-version
grid_color_shader = TilePaletteMapper(shader_palette, 2, SCREEN_WIDTH, SCREEN_HEIGHT)
This code works fine in 9.x but fail in 10.x.
Additional information
This is a breaking change, and I have not found a syntax that would make the same code work in 9.x and 10.x
There must be a better way to do that, or if not, to document that breaking change and suggest what to change in the code when going from 9 to 10.
Also a search for all usage of tilepalettemapper.TilePaletteMapper in Learn Guide to identify what guide need a fix would be needed (but maybe this is unique?).