shared-bindings/sdioio/SDCard.c: fix example use of board.SDIO_DATA
#10464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
board.SDIO_DATAon a number of boards is a tuple of four pins for use withsdioio.SDCARD(..., data=...)The example in
sdioioincorrectly put it in square brackets:[board.SDIO_DATA]. Remove those to use the intended tuple, and also include a sample line for boards that do not have this tuple but haveboard.SDIO_DATA0, board.SDIO_DATA1, board.SDIO_DATA2, board.SDIO_DATA3pins instead.Thanks
Seth Kin discord for discovering the doc problem.I've also updated some examples in Learn Guides to point out
board.SDIO_DATAis a tuple.Maybe the tuple should be called
board.SDIO_DATA_PINS, but good documentation will help for now.