go tool fixes

Author: bryanmacfarlane

.zshrc

@@ -3,6 +3,7 @@ export DOT_FILES_PATH=$(dirname $(readlink ~/.zshrc))
 export DOT_DOT_PATH="${DOT_FILES_PATH}/dot"
 export DOT_TOOLS_PATH="${DOT_FILES_PATH}/tools"
 
+source "${DOT_FILES_PATH}/dot/common.sh"
 source "${DOT_FILES_PATH}/dot/load.sh"
 
 # workspaces is either in ~/Projects or in codespaces it's in /codespaces
@@ -23,10 +24,6 @@ PROMPT='%(?.%F{green}√.%F{red}?%?)%f %B%F{250}%1~%f%b %(!.#.$) '
 
 dot_load
 dot_help
-
-# "${DOT_FILES_PATH}/dot/tools.sh" "init"
-# dot_load_tools
-# echo
 dot_tools "init"
 
 # codespaces automatically takes you into that repo.  

dot/common.sh

@@ -19,6 +19,17 @@ popd () {
     command popd "$@" > /dev/null
 }
 
+# https://superuser.com/questions/39751/add-directory-to-path-if-its-not-already-there
+pathappend() {
+  for ARG in "$@"
+  do
+    if [ -d "$ARG" ] && [[ ":$PATH:" != *":$ARG:"* ]]; then
+        echo "appending path ${ARG}"
+        PATH="${PATH:+"$PATH:"}$ARG"
+    fi
+  done
+}
+
 cprint() {
     # https://stackoverflow.com/a/64824268/775184
     intense='1'

rc/tools.sh

@@ -30,7 +30,9 @@ dot_tools() {
         "dot_tools_$cmd" "$@"
 
         # reload tools env and paths
-        dot_tools_init
+        if [ "$cmd" != "init" ]; then 
+            dot_tools_init
+        fi
     else
         dot_tools_ls
     fi 

tools/go_init

@@ -2,15 +2,16 @@
 export TOOL_GO_PATH="/usr/local/go/bin"
 export TOOL_GO_BIN="$HOME/go/bin"
 
-init() {
-    if [ -d  ${TOOL_GO_PATH} ]; then
-        if [ ! -x "$(command -v go)" ]; then 
-            echo "Adding go to PATH"
-            export PATH=$PATH:${TOOL_GO_PATH}
-        fi
+if [ -d ${TOOL_GO_PATH} ]; then
+    # -x tests for execute permission and exists 
+    if [ ! -x "$(command -v go)" ]; then 
+        echo "Adding go to PATH"
+        pathappend "${TOOL_GO_PATH}"
+        # export PATH=$PATH:${TOOL_GO_PATH}
+    fi
 
-        if [ -d ${TOOL_GO_BIN} ]; then
-            export PATH=$PATH:${TOOL_GO_BIN}
-        fi
+    if [ -d "${TOOL_GO_BIN}" ]; then
+        pathappend "${TOOL_GO_BIN}"
+        # export PATH=$PATH:${TOOL_GO_BIN}
     fi
-}
+fi