CLJS-3438: Inference for goog.object/containsKey returns any, not boolean
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolean - fix desugar-dotted-expr, generated malformed AST in the case of goog.module var - compiler test for goog.object/containsKey - uncomment test now passes ... but compiler-tests are failing due to warning about incorrect usage of goog.object/get, but that's because we don't parse options params yet also need to resolve to the original goog.module var name and not the local thing in the namespace
- check for the unaliased-name when warning about arity in parse-invoke*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix desugar-dotted-expr, generated malformed AST in the case of
goog.modulevarcompiler test for
goog.object/containsKeyuncomment test, now passes
but compiler-tests are failing due to warning about incorrect usage of
goog.object/get, but that's because we don't parse optional params yet, need to fixcljs.externsalso need to resolve to the original
goog.modulevar name and not the local thing in the namespace. Probably want to mark these somehow so that the warnings can use the original name.