Skip to content

[Rules] Update error page types #22830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pedrosousa
Copy link
Contributor

Summary

Addresses PCX-17662.

@github-actions github-actions bot added product:rules Related to rules size/xs labels Jun 2, 2025
Copy link
Contributor

hyperlint-ai bot commented Jun 2, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated error page types and clarified the distinction between different challenge types.

  • Revised example for custom error pages to include 'WAF block' instead of 'Interactive Challenge'.
  • Added information about error page types that are discouraged in favor of managed challenges.

Modified Files

  • src/content/docs/rules/custom-errors/edit-error-pages.mdx
  • src/content/docs/rules/custom-errors/reference/error-page-types.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/rules/ @pedrosousa, @cloudflare/pcx-technical-writing

@github-actions github-actions bot added size/m and removed size/xs labels Jun 3, 2025
@pedrosousa pedrosousa marked this pull request as ready for review June 3, 2025 11:05
@pedrosousa pedrosousa requested a review from a team as a code owner June 3, 2025 11:05
@nikitacano nikitacano enabled auto-merge (squash) June 3, 2025 16:37
@nikitacano nikitacano merged commit d12eefe into production Jun 4, 2025
11 checks passed
@nikitacano nikitacano deleted the pedro/PCX-17662-rules-update-error-page-types branch June 4, 2025 08:56
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
* [Rules] Update error page types

* Adjust sentence

* Add error page example API calls

* Add API identifiers to page types list

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:rules Related to rules size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants