Skip to content

Tell the reader to remove unwanted binding property in "Pages to Workers" migration docs #22833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: production
Choose a base branch
from

Conversation

petebacondarwin
Copy link
Contributor

This was brought up in the Wrangler Discord office hours

Documentation checklist

…rkers" migration docs

This was brought up in the Wrangler Discord office hours
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

@github-actions github-actions bot added the product:workers Related to Workers product label Jun 2, 2025
Copy link
Contributor

hyperlint-ai bot commented Jun 2, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated migration documentation to clarify the removal of the binding property for Workers containing only assets.

  • Added a note advising users to remove the binding property if no Worker script is present.
  • Clarified the conditions under which the binding property is valid.

Modified Files

  • src/content/docs/workers/static-assets/migration-guides/migrate-from-pages.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/static-assets @irvinebroque, @GregBrimble, @WalshyDev, @kodster28, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants