-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update authorization header and clarify API usage #22847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authorization header and clarify API usage #22847
Conversation
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (1)
- src/content/docs/agents/model-context-protocol/mcp-servers-for-cloudflare.mdx (13-13) The removal of the first part of the sentence ('These MCP servers allow your MCP Client to read configurations from your account, process information, make suggestions based on data, and even make those suggested changes for you.') creates a disconnected statement. The sentence now starts with 'All of these actions...' without explaining what actions are being referred to. Consider keeping the first part of the sentence or rewriting it to maintain clarity.
@@ -30,7 +30,7 @@ Alternatively, you can use the command line as shown below to create a new MCP S | |||
|
|||
<PackageManagers | |||
type="create" | |||
pkg="cloudflare@latest" | |||
pkg="Cloudflare@latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name should remain lowercase as cloudflare@latest
. The npm package is published as lowercase 'cloudflare' (https://www.npmjs.com/package/cloudflare), and changing it to uppercase 'Cloudflare' would cause the package manager commands to fail.
@@ -118,7 +118,7 @@ Run the following command to create a new MCP server: | |||
|
|||
<PackageManagers | |||
type="create" | |||
pkg="cloudflare@latest" | |||
pkg="Cloudflare@latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name should remain lowercase as cloudflare@latest
. The npm package is published as lowercase 'cloudflare' (https://www.npmjs.com/package/cloudflare), and changing it to uppercase 'Cloudflare' would cause the package manager commands to fail.
@@ -77,7 +77,7 @@ export default { | |||
provider: "compat", | |||
endpoint: "chat/completions", | |||
headers: { | |||
authorization: "Bearer ", | |||
authorization: "Bearer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The authorization header should include a space after 'Bearer'. According to OAuth 2.0 standards, the format should be 'Bearer {token}' with a space between 'Bearer' and the token value.
authorization: "Bearer", | |
authorization: "Bearer ", |
This pull request addresses several style guide violations, including incorrect casing for 'Cloudflare', removal of extraneous characters, and the use of contractions. The changes ensure compliance with the established style guide rules.
add-human-feedback-api.mdx
)add-human-feedback-api.mdx
)chat-completion.mdx
,add-human-feedback-api.mdx
)