-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[DNS] API docs link review #22853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNS] API docs link review #22853
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated API documentation links for DNS settings to reflect the correct endpoint paths.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
@@ -148,8 +148,8 @@ To remove ACNS from a zone, first update your nameservers to stop using ACNS: | |||
</TabItem> | |||
<TabItem label="API"> | |||
|
|||
* If you are using [Cloudflare Registrar](/registrar/), use the [Update DNS settings endpoint](/api/resources/dns/subresources/settings/methods/edit/) to change the `enabled` parameter to `false`, and then [contact Cloudflare Support](/support/contacting-cloudflare-support/) to set your nameservers back to the regular Cloudflare branded nameservers. | |||
* If you are not using [Cloudflare Registrar](/registrar/), modify the domain's registrar to use your regular Cloudflare branded nameservers and then use the [Update DNS settings endpoint](/api/resources/dns/subresources/settings/methods/edit/) to set the `enabled` parameter to `false`. | |||
* If you are using [Cloudflare Registrar](/registrar/), use the [Update DNS settings endpoint](/api/resources/dns/subresources/settings/subresources/zone/methods/edit/) to change the `enabled` parameter to `false`, and then [contact Cloudflare Support](/support/contacting-cloudflare-support/) to set your nameservers back to the regular Cloudflare branded nameservers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that endpoint, the user needs to set the type
parameter in the nameservers
object to "cloudflare.standard"
in order to move back to Cloudflare standard nameservers.
* First pass with find and replace * Fix deprecations yaml differentiating zone vs account * Update links to DNS settings for account * Fix broken link prior to review of disablement flow * Adjust disable instructions to account for current endpoint
Summary
PCX-14409
Change from
/api/resources/dns/subresources/settings/methods/edit/
to/api/resources/dns/subresources/settings/subresources/zone/methods/edit/
for zone-level/api/resources/dns/subresources/settings/subresources/account/methods/edit/
for account-level