Skip to content

add codspeed benchmark runner #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

add codspeed benchmark runner #4394

merged 1 commit into from
Jul 2, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 23, 2025

Completes the work started by @art049 at #4137

@anonrig anonrig requested review from a team as code owners June 23, 2025 17:04
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch from d08b0ad to ec346f1 Compare June 23, 2025 17:05
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch 4 times, most recently from 0ff07e7 to a32f05a Compare June 23, 2025 17:11
@anonrig anonrig requested review from mikea and fhanau June 23, 2025 17:12
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch 2 times, most recently from d61f07f to f841c2f Compare June 23, 2025 17:37
Copy link

codspeed-hq bot commented Jun 23, 2025

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 0 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

@danlapid
Copy link
Collaborator

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 10 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • ParseAndSerialize (17.7 µs)
  • Serialize (4.4 µs)
  • constructor[ApiHeaders] (27.9 µs)
  • SlowAPIWithLock[FastMethodFixture] (3.7 ms)
  • SlowAPI[FastMethodFixture] (4 ms)
  • request[GlobalScopeBenchmark] (331 µs)
  • Test_JSON_DEC (74.4 µs)
  • Test_JSON_ENC (43.7 µs)
  • Parse[KjHeaders] (8.8 µs)
  • request[RegExpBenchmark] (7.2 ms)

These numbers are likely too small to be used for performance comparisons, I think aiming for 5-10ms per benchmark test is likely a good starting point, microseconds benchmarks likely need more iterations

@anonrig
Copy link
Member Author

anonrig commented Jun 25, 2025

These numbers are likely too small to be used for performance comparisons, I think aiming for 5-10ms per benchmark test is likely a good starting point, microseconds benchmarks likely need more iterations

Agreed. I think we should make an update to all benchmarks after this pull-request lands. Most of those benchmarks are not needed, but I'm pretty sure it's up to the discussion.

@anonrig anonrig force-pushed the yagiz/enable-codspeed branch 2 times, most recently from ba9a38d to c8e1d1b Compare June 27, 2025 13:41
@anonrig anonrig requested a review from danlapid June 27, 2025 16:54
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch from c8e1d1b to 6699527 Compare June 30, 2025 13:44
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch 2 times, most recently from 688ed66 to 58a6ce9 Compare July 2, 2025 21:17
do not build bench-tools on windows

use local repository for google benchmark

revert ci.bazelrc changes
@anonrig anonrig force-pushed the yagiz/enable-codspeed branch from 58a6ce9 to b09b0b3 Compare July 2, 2025 21:19
@anonrig anonrig requested a review from fhanau July 2, 2025 21:21
@anonrig anonrig merged commit f17e8f1 into main Jul 2, 2025
19 of 21 checks passed
@anonrig anonrig deleted the yagiz/enable-codspeed branch July 2, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants