Skip to content

fix(_includes): update navigation per Jekyll tutorial #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

francisfuzz
Copy link
Contributor

Closes #95.

Summary

👋 Hello, codeandcoffeelb! I know @karimamer is assigned to the original issue, so I'm happy to yield to their changes and you're more than welcome to close this out.

Approach

This is my take drawing from the approach recommended in https://jekyllrb.com/tutorials/navigation/:

  • creates a YAML file in the _data defining the navigation items
  • updates includes/navigation.html to use one conditional to omit the home page at root and a for iterator to render all navigation items

I tested my changes locally by spinning up the Dockerfile defined in this repo to ensure what I've proposed is functional. Here's a motion picture, if it helps!

new-navigation-walkthrough

Next steps

Requesting review from @davidnuon as the maintainer of this organization (please correct me if I'm wrong 🙇 ). I've allowed edits from maintainers in the case there's anything you'd like to modify. I'm open to receive any feedback about my implementation––I'm not tied down to anything in particular. Ultimately, I'd just like to see Navigation fixed for your site! 😎

@davidnuon davidnuon merged commit 4c0b7f4 into codeandcoffeelb:development Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigation is broken
2 participants