fix(_includes): update navigation per Jekyll tutorial #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95.
Summary
👋 Hello, codeandcoffeelb! I know @karimamer is assigned to the original issue, so I'm happy to yield to their changes and you're more than welcome to close this out.
Approach
This is my take drawing from the approach recommended in https://jekyllrb.com/tutorials/navigation/:
_data
defining the navigation itemsincludes/navigation.html
to use one conditional to omit the home page at root and afor
iterator to render all navigation itemsI tested my changes locally by spinning up the
Dockerfile
defined in this repo to ensure what I've proposed is functional. Here's a motion picture, if it helps!Next steps
Requesting review from @davidnuon as the maintainer of this organization (please correct me if I'm wrong 🙇 ). I've allowed edits from maintainers in the case there's anything you'd like to modify. I'm open to receive any feedback about my implementation––I'm not tied down to anything in particular. Ultimately, I'd just like to see Navigation fixed for your site! 😎