Skip to content

Conversation

@libmartinito
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jul 20, 2023

CC-627 Fix lint error with new eslint-plugin-qunit

Here's the error: #597

[lint:js] /home/runner/work/frontend/frontend/tests/acceptance/pay-test.js
[lint:js]   16:3  error  Unexpected use of `assert.expect()` call  qunit/require-expect

I think the way we're using expect is reasonable - we're using it to check that the expect block gets called. There's a discussion about this here too: qunitjs/eslint-plugin-qunit#382.

Let's disable this rule (qunit/require-expect) for that specific usage + update the dependabot PR

@lintrule-review
Copy link

Checks passed

  • Ran no-bugs.md on tests/acceptance/pay-test.js

@libmartinito libmartinito merged commit 995c780 into master Jul 20, 2023
@libmartinito libmartinito deleted the CC-627 branch July 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants