Update to node20 for #1698

[dherbst]

Summary

Updated to use node20 for #1698 in the relevant docker files and firebase.json file.

Note, I left "@tsconfig/node16": "^1.0.2", in the devDependencies.

Checklist

• On the frontend, I've made my strings translate-able.
• If I've added shared components, I've added a storybook story.
• I've made pages responsive and look good on mobile.

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

1. Go to the home page
2. Click on a testimony
3. See that it's loaded with a loading spinner

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maple-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2025 1:22pm

[Mephistic]

Thanks for picking this up! Looks like this also needs to update out Github Actions setup-repo to use a newer version of node for the build to pass on the Github runner.

[dherbst]

Ok I'll take a look this morning

[dherbst]

I've updated .github/actions/setup-repo/action.yml to use actions/setup-node@v4 and set default to node 20.

[dherbst]

This may require the firebase-functions and firebase-admin packages to be upgraded. I'll look into this.

[Mephistic]

Thanks for taking a look at upgrading the firebase-* versions! For context, there is another issue open for upgrading the firebase-functions version (#1588) that another volunteer just had to pivot away from to focus on something time-sensitive.

[dherbst]

No problem. It doesn't look like this is a quick change to the node version, like I thought it was going to be.

[dherbst]

Converting this to draft because I have to change admin to use v1.

[dherbst]

I have been able to upgrade firebase-functions and firebase-admin so nodejs20 can be used.

I was running into an issue with the TextEncoder when running the test:integration-ci tests locally, but now the vercel check doesn't like that.

I'm having trouble getting the integration tests to run, because when the maple package code imports code in the functions package, something is not allowing it to resolve the firebase-functions/v1 import correctly. I think the next step is to look at the integration tests to see if they really need to do cross package imports and maybe refactor them to simplify the imports.