[iOS] SwipeView Closes when Content Changes - right and bottom - fix #30182
+6,942
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a large number of new and updated test cases spanning multiple issues to help ensure correct behavior across platforms. Key changes include new UI tests for issues such as SwipeView behavior (Issue29086), CollectionView layout (Issue29634, Issue29542), various Image and Button feature tests, and consistent namespace updates across test projects.
Reviewed Changes
Copilot reviewed 117 out of 460 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/Issues/Issue29233.cs | Removed an extra "Tests" segment from the namespace. |
| HostApp/Issues/Issue7144.cs | Updated the namespace to align with new naming conventions. |
| HostApp/Issues/Issue6387.cs | Updated the namespace for consistency with current conventions. |
| HostApp/Issues/Issue15649.xaml.cs | Adjusted the namespace to follow the new standard for host app issues. |
Comments suppressed due to low confidence (4)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29233.cs:6
- The redundant 'Tests' segment in the original namespace has been removed, which improves clarity. Please confirm that all references to this namespace are updated accordingly.
namespace Microsoft.Maui.TestCases.Tests.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue7144.cs:3
- The namespace has been updated from 'Controls.TestCases.HostApp.Issues' to 'Maui.Controls.Sample.Issues' to align with current conventions. Ensure consistency across all host app issue files.
namespace Maui.Controls.Sample.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue6387.cs:1
- Namespace change to 'Maui.Controls.Sample.Issues' aligns with project standards; verify that dependent references are updated accordingly.
namespace Maui.Controls.Sample.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue15649.xaml.cs:1
- Updating the namespace in this file to 'Maui.Controls.Sample.Issues' promotes consistency with other host app files. Please ensure any related XAML references are also updated.
namespace Maui.Controls.Sample.Issues;
kubaflo
changed the title
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jun 25, 2025
…="False" and user scroll to the last position - fix (dotnet#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
…roundColor dotnet#22914 (dotnet#22917) * Fixes dotnet#22914 * Add tests Add tests for appium * Fix the build * Use VerifyScreenshot * @jsuarezruiz suggested changes --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
* Fixed the picker title's color (dotnet#16737) * Added a test category * Enable test on all platforms
If no QueryIcon / ClearIcon is specified use default icon.
* button test cases added * added clear text line * changes * added test fails condition * updated test cases * updated the test cases * updated test cases * added additional test cases * removed test case * added snapshots * added the windows and mac snapshots * removed snapshots * added additional properties * added mac and windows snapshots
* harish_feature_matrix_boxview * Added the Snapshots * Updated the Snapshots * Renamed the file * Added property and Updated Snaps * Resaved Snapshots from latest build
…on (dotnet#20048) * add benchmarks * set CanConvertTo to be consistent with the ColumnDefinitionTypeConverter * optimize GridLength conversion * optimize grid definition conversion * enable nullable types * fix build * reduce diff * Slightly better * Update RowDefinition.cs * Even better --------- Co-authored-by: Edward Miller <symbiogenisis@outlook.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
…net#29934) * Update ViewExtensions.cs * Update ViewExtensions.cs * Update ViewExtensions.cs * - unsubscribe sooner --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
…nd BackgroundColor (dotnet#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
…t#29896) * Add Button to HandlerDoesNotLeak test * add ProgressBar to HandlerDoesNotLeak
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…es BackgroundColor dotnet#22914 (dotnet#22917)" (dotnet#30031) This reverts commit 19402d3.
* Weak subscription to CanExecuteChange events * - add tests * - fix lifecycle of CanExecute subscription * - cleanup code based on Pictos recommendations * - add a netstandard_20 version of DependentHandle * - add more * - fix missing null check on textcell
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…raphicsView (dotnet#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
* make picker not focisable # Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt * Address review comments * set keylistner to null * Make sure Focus()/Unfocus() works * Address review comments * Remove IsFocused Checks
* Reverting the OnMeasure changes and 27614 test cases * Resaved the Android images * Change in unshipped file
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…resizing when bounds change (dotnet#29639) * Fix CV1 empty view not resizing when bounds change and grid layout not left aligning single item * - rework test * - fix test --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#29980) * added test cases * modified test cases * added snapshots * added mac and windows snapshots
…#29968) * Added ImageButton Feature tests * Changes updated * Modified tests * Added Images * Modified image * Added images --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
…dows (dotnet#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…l image, even when disposeOriginal is set to true (dotnet#29936) * Fix for original image disposal when disposeOriginal is true in Resize and Downsize methods on Android and iOS * Updated the fix for iOS, and modified the test case to reflect the changes * Updated the issue link in test case
* Added Label Feature Tests * Changes updated * Added properties for Image control * Added Images * changes updated * Added images * changes updated * Added images --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
* [iOS] SwipeView Closes when Content Changes - fix * Added snapshots
…er switching activities (dotnet#28767) * Fixing issue dotnet#24357 by removing outdated menu items as Android can delete them after switching activities * Disposing outdated IMenuItem just in case * Reduced memory allocation * Tuned performance a bit
…s into device tests - 6 (dotnet#28399) * Enabled the translation property for device tests * Added the helper method * Reverted the changes * Updated EditorTests.Android.cs * Fix formating
…m the navigation stack (dotnet#30049) * Update NavigationProxy.cs * test case added * Update Issue29923.cs * fix updated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PureWeen
force-pushed
the
inflight/current
branch
from
3310b65 to
f8f04ff
Compare
…eration Disabled (dotnet#28934) * Update WebViewHandler.Android.cs * Test case added * Update WebView.cs * fix updated * Update WebView.cs * Create ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png * updated test case codes * Update ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png * Update Issue28798.cs * Update ControlsShouldRemainVisibleWithWebViewWhenHardwareAccelerationIsDisabled.png updated google with example.com as google logo keeps changing.
github-actions
bot
force-pushed
the
inflight/current
branch
from
4684ea4 to
2938eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
A correction to this pr #29088 that fixes this comment #29088 (comment)
Issues Fixed
Fixes #29088 (comment)
Screen.Recording.2025-06-25.at.02.27.34.mov
Screen.Recording.2025-06-25.at.02.26.43.mov