[Testing] Feature matrix UITest Cases for ScrollView Control #30188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a full suite of UI test cases for the ScrollView control and implements the corresponding view model and pages in the HostApp to drive those tests.
- Introduces
ScrollViewFeatureTests.cswith ordered UITest methods covering content types, orientations, scrolling positions, and properties. - Implements
ScrollViewViewModel,ScrollViewOptionsPage, andScrollViewControlPage(XAML + code-behind) to power the feature matrix UI. - Registers the new ScrollView feature page in the gallery via
CorePageView.cs.
Reviewed Changes
Copilot reviewed 7 out of 158 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/ScrollViewFeatureTests.cs | New UITest methods validating ScrollView behaviors |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewViewModel.cs | Added view model tracking ScrollView state and properties |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewOptionsPage.xaml | New XAML UI for selecting ScrollView options |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewOptionsPage.xaml.cs | Code-behind wiring option buttons |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewControlPage.xaml | XAML UI for the ScrollView display and controls |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewControlPage.xaml.cs | Code-behind handling navigation, scrolling events, and bindings |
| src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs | Registered the new ScrollView feature matrix in the gallery |
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/ScrollViewFeatureTests.cs:333
- Method name is missing 'Layout' in 'AbsoluteContent'; it should be 'MakeVisibleAndAbsoluteLayoutContent' for consistency.
public void VerifyScrollViewWithScrollToPositionMakeVisibleAndAbsoluteContent()
src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewOptionsPage.xaml.cs:38
- [nitpick] Local variable 'Imagewidth' should use camelCase (e.g. 'imageWidth') to follow C# naming conventions.
double Imagewidth = 1300;
|
|
||
| [Test, Order(47)] | ||
| [Category(UITestCategories.ScrollView)] | ||
| public void VerifyScrollViewWithScrollToPositionCenterAndHorizontalLayoutontentWhenOrientationHorizontal() |
There was a problem hiding this comment.
Typo in method name: 'Layoutontent' should be 'LayoutContent' to match the pattern of other tests.
Suggested change
| public void VerifyScrollViewWithScrollToPositionCenterAndHorizontalLayoutontentWhenOrientationHorizontal() | |
| public void VerifyScrollViewWithScrollToPositionCenterAndHorizontalLayoutContentWhenOrientationHorizontal() |
Copilot uses AI. Check for mistakes.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a comprehensive set of UI test cases for the Scrollview control. The tests validate the ScrollView control, including properties such as Content, Orientation, HorizontalScrollBarVisibility, VerticalScrollBarVisibility, ScrollX , ScrollY, FlowDirection, IsEnabled, IsVisible.
Issues Identified
Screen.Recording.2025-06-25.at.12.10.57.PM.mov