Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" #30222
+2
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to main |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in PR 29497 that attempted to update the SearchHandler’s Query-dependent text dynamically. The key changes include removing tests for Issue14497 and reverting the Query update logic in the iOS and Android SearchHandlerAppearanceTracker implementations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs | Removed tests for the dynamic query update issue |
| src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs | Removed host app test for the dynamic query update issue |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs | Removed query update code in the iOS appearance tracker |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs | Removed query update code in the Android appearance tracker |
Comments suppressed due to low confidence (4)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs:113
- The removal of the QueryProperty check and its associated UpdateText method reverts the behavior for iOS; please double-check that this change aligns with the intended user experience and that any dependent code is adjusted accordingly.
}
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs:89
- The removal of the query update block and the UpdateText method in the Android tracker reverts previous functionality; please verify that this change fully restores the earlier behavior expected by users.
}
|
Started backporting to main: https://github.com/dotnet/maui/actions/runs/15887474419 |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/maui/actions/runs/15906335749 |
mattleibow
previously approved these changes
Jun 26, 2025
jsuarezruiz
previously approved these changes
Jun 27, 2025
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/maui/actions/runs/15925813840 |
|
/rebase |
…ty does not update text in the search box (#28400)" This reverts commit 559da79. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs
…rty (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs
github-actions
bot
force-pushed
the
revert_28400
branch
from
4e7e717 to
31f56e6
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
rmarinho
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR reverts #29497
The changes that will need to be made to fix this properly I think are too substantial to be include in a backport fix so we are going to revert this for now and try to get a more proper fix for SR9 (though it might slip to SR10)
Issues Fixed
Fixes #30072