[Android] Exception thrown when give more than 5000 characters to the Text property of Entry. #30242
Conversation
dotnet-policy-service
bot
added
community ✨
KarthikRajaKalaimani
changed the title
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| [Fact(DisplayName = "Android crash when Entry has more than 5000 characters")] | ||
| [Category(TestCategory.Entry)] | ||
| public async Task EntryWithLongTextAndIsPassword_DoesNotCrash() |
There was a problem hiding this comment.
In addition to test the initialization, could you include another test updating the Text value?
There was a problem hiding this comment.
In addition to test the initialization, could you include another test updating the Text value?
I have added an additional test case that updates the Text value.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -23,14 +23,14 @@ public partial class EntryHandler : IEntryHandler | |||
| [nameof(IEntry.CharacterSpacing)] = MapCharacterSpacing, | |||
| [nameof(IEntry.ClearButtonVisibility)] = MapClearButtonVisibility, | |||
| [nameof(IEntry.Font)] = MapFont, | |||
| [nameof(IEntry.MaxLength)] = MapMaxLength, | |||
There was a problem hiding this comment.
I worry about depending on the property mapper ordering. That feels a bit fragile.
One approach you can also take is multiple mappers that you pass into the main mapper ctor
I've also prompted copilot here to see what it thinks
#30302 (comment)
There was a problem hiding this comment.
I worry about depending on the property mapper ordering. That feels a bit fragile.
One approach you can also take is multiple mappers that you pass into the main mapper ctor
I've also prompted copilot here to see what it thinks #30302 (comment)
I reviewed the Copilot suggestion, and it appears to propose multiple fixes: reordering the mapping and applying a condition-based max length. Either approach should work if implemented. Would you like to implement both solutions, or just one?
I'm not quite clear on what you meant by, "you can also take multiple mappers that you pass into the main mapper constructor". Could you provide more insight?
There was a problem hiding this comment.
I reviewed the Copilot-suggested fix and ensured that it works as expected. I then modified the fix and added a new test case to validate the MaxLength property behavior. The test has been written to run across all platforms.
Issue Details:
Exception thrown when give more than 5000 characters to the Text property of Entry on Android platform.
Root Cause:
When the Entry contains more than 5000 characters and the IsPassword property is mapped before the MaxLength property, the EditText input type is set to InputTypes.ClassText | InputTypes.TextVariationNormal. After the input type is updated, we attempts to restore the previous cursor position, which exceeds 5000 characters. This results in an IndexOutOfBoundsException during the selection process.
Description of Change:
To prevent the crash, I reordered the property mappers by applying the MaxLength mapper before the IsPassword mapper in EntryHandler
Tested the behavior in the following platforms.
Reference:
N/A
Issues Fixed:
Fixes #30144
Screenshots