Skip to content

Disable WER for host test apps that intentionally crash #116936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

elinor-fung
Copy link
Member

Call SetErrorMode with NOGPFAULTERRORBOX per @MichalStrehovsky's suggestion in #116725 (comment)

This disables dumps for the tests that intentionally crash when we are crashing from the app. For something like Muxer_NonAssemblyWithExeExtension where there is no test-specific code running, we don't have anywhere to hook in to do this, so that still ends up with a dump. But this change at least gets rid of the other ones.

cc @dotnet/appmodel @AaronRobinsonMSFT

@elinor-fung elinor-fung added this to the 10.0.0 milestone Jun 23, 2025
@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 22:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables Windows error reporting for host test applications that intentionally crash by calling SetErrorMode with the NOGPFAULTERRORBOX flag.

  • Disables core dumps for specific Windows tests
  • Adds Windows-specific error mode handling in CoreDump.cs
Comments suppressed due to low confidence (1)

src/installer/tests/Assets/Projects/CoreDump.cs:37

  • [nitpick] Consider adding a brief inline comment explaining why SetErrorMode is called with NOGPFAULTERRORBOX on Windows to improve maintainability and clarify intent for future reviewers.
            else if (OperatingSystem.IsWindows())

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit e40ca05 into dotnet:main Jun 24, 2025
76 of 78 checks passed
@elinor-fung elinor-fung deleted the hostTest-setErrorMode branch June 24, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants