Disable WER for host test apps that intentionally crash #116936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
SetErrorMode
withNOGPFAULTERRORBOX
per @MichalStrehovsky's suggestion in #116725 (comment)This disables dumps for the tests that intentionally crash when we are crashing from the app. For something like
Muxer_NonAssemblyWithExeExtension
where there is no test-specific code running, we don't have anywhere to hook in to do this, so that still ends up with a dump. But this change at least gets rid of the other ones.cc @dotnet/appmodel @AaronRobinsonMSFT