Skip to content

[Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces #18583

Open
ecomfe/zrender
#1006
@Wetterquarz

Description

@Wetterquarz

Version

5.0.0 - 5.4.2
5.4.3-dev.20230502
5.5.0-dev.20230501

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=line-marker&code=PYBwLglsB2AEC8sDeAoWtJgDYFMBcya6GOAHmAQOQAqOAtiDgE4CGYArkzrAMIAWLaAHNuEOGD7cewOmKGwA6jhwBrADSxBAE02wsMeWDJgMkriwBmRphmCwLwJgGNuAd1YgQc27AGeccK4QEpqAPBuAhjsRUZEx0ZRqROhG5ADKYACeuASoxMTAAG7MFvquVABG5irxicRBWhIEACwADABMNQC-RB0JHQDcQA

Steps to Reproduce

  1. Create a chart with any text and set it up to wrap set text when overflowing.
  2. Use characters of the so-called non-BMP.
  3. Try some widths until you break within the character or before a space (or both as in the minimal reproduction)

Current Behavior

image
The 3rd line starts with a space.
The 3rd line doesn't calculate the character widths correctly and is short.
One of the Domino Tiles has been broken into two illegal characters.

Expected Behavior

According to the Unicode Standard (https://www.unicode.org/reports/tr14/#SP) the wrapping should occur after all space-characters when a line-break is desired by the algorithm. Characters should also, obviously, not be broken in two and their width should be correctly determined.

Environment

- OS: Windows 10
- Browser: Edge 112.0.1722.58 (Chromium)

Any additional comments?

No response

Activity

added
enThis issue is in English
pendingWe are not sure about whether this is a bug/new feature.
on May 2, 2023
removed
pendingWe are not sure about whether this is a bug/new feature.
on Jun 13, 2023
added this to the TBD milestone on Jun 13, 2023
added
difficulty: easyIssues that can be fixed more easily than the average.
on Jun 13, 2023
echarts-bot

echarts-bot commented on Jun 13, 2023

@echarts-bot

This issue is labeled with difficulty: easy.
@Wetterquarz Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

Wetterquarz

Wetterquarz commented on Jul 24, 2023

@Wetterquarz
Author

There already is a pull request pending (ecomfe/zrender#1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdifficulty: easyIssues that can be fixed more easily than the average.enThis issue is in English

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @Ovilia@Wetterquarz

      Issue actions

        [Bug] Zrender Overflow Word Wrapping can Break Apart Characters and can Break Before Spaces · Issue #18583 · apache/echarts