Skip to content

useDirtyRect = true and saving image shows "Save as Image" label #16534

Not planned
ecomfe/zrender
#891
@dirslashls

Description

@dirslashls

Version

5.0.0

Link to Minimal Reproduction

No response

Steps to Reproduce

  1. Go to https://echarts.apache.org/examples/en/editor.html?c=line-step
  2. Turn on "Use Dirty Rect"
  3. Download the image.

Current Behavior

It contains the "Save as Image" label.

Expected Behavior

It should not contain the "Save as Image" label in the image.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response

Activity

echarts-bot

echarts-bot commented on Feb 18, 2022

@echarts-bot

This issue is labeled with difficulty: easy.
@dirslashls Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

dirslashls

dirslashls commented on Feb 21, 2022

@dirslashls
Author

I am not 100% sure but I think excluded elements during rendering for image need to be explicitly cleared when setting useDirtyRect to true.

linghaoSu

linghaoSu commented on Feb 24, 2022

@linghaoSu
Member

@plainheart hi, I find the problem that caused the current issue in zrender, could you help me to review my pr?

github-actions

github-actions commented on Feb 24, 2024

@github-actions
Contributor

This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.

added
staleInactive for a long time. Will be closed in 7 days.
on Feb 24, 2024
github-actions

github-actions commented on Mar 3, 2024

@github-actions
Contributor

This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    difficulty: easyIssues that can be fixed more easily than the average.enThis issue is in EnglishpendingWe are not sure about whether this is a bug/new feature.staleInactive for a long time. Will be closed in 7 days.topic: toolboxwaiting-for: community

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @dirslashls@plainheart@linghaoSu

      Issue actions

        useDirtyRect = true and saving image shows "Save as Image" label · Issue #16534 · apache/echarts